Trying to run Army's TS macs . . . (1 Viewer)

[toejam]

I was wondering if someone had the time to tell me what I need to change in Army's TS macs to get it to stop crashing me. ie when I run the smithing one it does ok until it gets to the part that it has to 'clik' on the forge to open it:
Facing 'Forge'...
'item' mouse click is either invalid or should be done using /notify
smith.mac@177 (Main): /click left item

If I don't manually clik the forge I crash to desktop after a few seconds.

Anyone tell me what I need to fix? This also happens to me when I try the brew mac.

Many thanks in advance.
Toejam ))

 

[Jmo]

Try the copies that I put in my compile Macros folder. I had slowed down the delay a bit because they caused me to crash too. If that doesn't work, I'd say post your copy of the macro and Siddin and Ccomp could probably take a look at it.

 

[toejam]

This is the smith mac and ini that I am using. I redownloaded your latest compile and did an extraction of the same files directly into my macro directory (to be sure I was using yours). Same problem. The same problem.

| Smith.mac version 1.0
|
| Written by Armysoldier
|
| March 5 2006
|
| Modifications:
|
| 23 APR 2006: added another loc to keep from getting stuck at forge
|
| 26 MAR 2006: moved 2 subs and event declarations to CommonSubs.inc
|
| This new line of tradeskill macros uses the NEW UI and the OLD UI for TS containers
| 
| The Macro will attempt to find the recipe using the NEW UI first
| If no recipe is found it will go Old school and do a set of combines
| these macros take into account the SALVAGE function and react accordingly
| 
|
| A special thanks to A_Druid_00 for advising on some streamlining modifications
| and to Override for his Tradeskill Code that has been around for so long 
| and is the inspiration for this code
|
| Some of the code was pulled from other macros and modified and manipulated 
| to do the tasks set forth.
|
| This code is designed for Abysmal Sea
|
| *** FOR THIS CODE TO WORK ***
| You need to Stand behind Snokin Breaksteel
| You need to be in the first person view
| You need to ensure that when you click the tradeskill container the NEW UI comes up first
| the 5 FILES need to be in the macro\common folder (see includes below)


#include common/sell.inc
#include common/buy.inc
#include common/packs.inc
#include common/cleanpacks.inc
#include common/CommonSubs.inc


Sub Main
    /declare OldSkill int outer ${Me.Skill[Blacksmithing]}
    /declare SkillMaxWanted int outer
    /declare PackCode string outer 
    /declare Component[10] string outer
    /declare i int outer
    /declare MerchantNameA string Outer
    /declare MerchantNameB string Outer
    /declare MerchantNameC string Outer
    /declare CombItemName string outer
    /declare ItemTo string outer
    /declare EndingVar int outer
    /declare DelayMult int outer
    /declare Container string outer
    /declare Checkrecipe string outer
    /declare NewUI int outer

|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Customize these settings if you want
|                    
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    /varset MerchantNameA "Snokin Breaksteel"
    /varset MerchantNameB "Cevroy Sharpaxe"
    /varset MerchantNameC "Dray Cuves"
    /varset SkillMaxWanted 115
    /varset DelayMult 1
    /declare Filename string outer Smithing.ini


|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Call Read INI for locations array
|                    
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    /call ReadINIA ${Filename} "Abysmal Sea" 
    /if (!${Defined[LocArray]}) { 
       /echo No Loc Array Created...
       /endmacro 
    } 

|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Begin 
|
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    :start

|--- Check Current Skill against Skill wanted 
    /echo Blacksmithing is at ${Me.Skill[Blacksmithing]}

    /if (${Me.Skill[Blacksmithing]}>=${SkillMaxWanted}) {
      /echo Blacksmithing is at ${SkillMaxWanted}. Quiting!
      /endmacro
    }

    /if (${Me.Skill[Blacksmithing]}<92) {
      /varset CombItemName "BG"
      /varset ItemTo "Banded Gorget"
    }
    /if (${Me.Skill[Blacksmithing]}>=92 && ${Me.Skill[Blacksmithing]}<102) {
      /varset CombItemName "BC"
      /varset ItemTo "Banded Cloak"
    }
    /if (${Me.Skill[Blacksmithing]}>=102 && ${Me.Skill[Blacksmithing]}<=115) {
      /varset CombItemName "BM"
      /varset ItemTo "Banded Mail"
    }

    /call ReadIni "${CombItemName}"
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| Buy Components
|
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

    /varset EndingVar 1
    /varset NewUI 1

    /target ${MerchantNameA}

    /nomodkey /click right target

    /delay 5s ${Window[MerchantWnd].Open}

    /call OpenPacks

    /call Buy "${Component[2]}" 30

    /nomodkey /notify MerchantWnd MW_Done_Button LeftMouseUp

    /echo Moving to ${MerchantNameB}

    /call Movement 1 4 2

    /target ${MerchantNameB}
   
    /delay 5s ${Target.ID}==${Spawn[${MerchantNameB}].ID}

    /nomodkey /click right target

    /delay 5s ${Window[MerchantWnd].Open}

    /call Buy "${Component[1]}" 10

    /nomodkey /notify MerchantWnd MW_Done_Button LeftMouseUp

    /echo Moving to ${MerchantNameC}

    /call Movement 5 11 9

    /target ${MerchantNameC}

    /delay 5s ${Target.ID}==${Spawn[${MerchantNameC}].ID}

    /nomodkey /click right target

    /delay 3s

    /call Buy "${Component[3]}" 40

    /nomodkey /notify MerchantWnd MW_Done_Button LeftMouseUp

    /call ClosePacks

    /echo Moving to the Forge

    /call Movement 12 17 14
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| MAKE Items
|
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

      /nomodkey /itemtarget forge notarget 
      /face item nolook 
      /click left item 

      /doevents 
      /delay 3s ${Window[TradeskillWnd].Open} 
      /if (!${Window[TradeskillWnd].Open}) /nomodkey /click left Item 
      /delay 3s ${Window[TradeskillWnd].Open} 
      /call ChooseRecipe
      /call ClosePacks

    /echo Moving to ${MerchantNameA}
    /echo Selling off and starting over
    /call Movement 22 22 0
    /call Movement 18 21 20

    /target ${MerchantNameA}
   
    /delay 5s ${Target.ID}==${Spawn[${MerchantNameA}].ID}

    /nomodkey /click right target

    /call OpenPacks

    /call Sell ${ItemTo}

    /call Sell ${Component[1]}

    /nomodkey /notify MerchantWnd MW_Done_Button LeftMouseUp

    /call ClosePacks

    /doevents

    /goto :start

    /return


|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|Sub Event Skill up
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 
Sub Event_Skillup
        /if (${Me.Skill[Blacksmithing]}>${OldSkill}) {
        /echo Your Blacksmithing Went Up!! It's now ${Me.Skill[Blacksmithing]}!
        /varset OldSkill ${Me.Skill[Blacksmithing]}
/return

|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|Sub Event No Longer Advance 
|used if there are some subcombines that need to be made in some TS
|~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Sub Event_Advance
    /varset EndingVar 2
/return

and this is the ini:

[Abysmal Sea]
Value=22
Loc1=130.49,259.22
Loc2=129.65,235.06
Loc3=35.36,235.70
Loc4=58.49,263.19
Loc5=-13.97,292.28
Loc6=-56.90,285.24
Loc7=-240.09,285.24
Loc8=-242.62,215.95
Loc9=-223.62,215.95
Loc10=-220.54,176.45
Loc11=-155.54,172.52
Loc12=-220.54,176.45
Loc13=-215.14,215.85
Loc14=-242.62,215.95
Loc15=-240.09,285.24
Loc16=-56.90,285.24
Loc17=62.90,293.24
Loc18=18.59,221.98
Loc19=126.89,236.86
Loc20=130.49,259.22
Loc21=92.71,259.21
Loc22=48.13,294.06


[BM]
Cont=Enviro
Comp0=mail sectional mold
Comp1=sheet metal
Comp2=water flask
Comp3=sheet metal
Comp4=sheet metal

[BG]
Cont=Enviro
Comp0=gorget mold
Comp1=sheet metal
Comp2=water flask
ItemTo=Banded Gorget

[BC]
Cont=Enviro
Comp0=cloak sectional mold
Comp1=sheet metal
Comp2=water Flask
Comp3=sheet metal

[FPV]
Cont=Enviro
Comp0=smithy hammer
Comp1=medium quality folded sheet metal 
Comp2=water Flask
Comp3=plate visor mold
Comp4=leather padding


[FPH]
Cont=Enviro
Comp0=smithy hammer
Comp1=medium quality folded sheet metal 
Comp2=water flask
Comp3=plate helm mold
Comp4=leather padding
Comp5=medium quality folded sheet metal 

[FPB]
Cont=Enviro
Comp0=smithy hammer
Comp1=medium quality folded sheet metal 
Comp2=water flask
Comp3=breastplate mold
Comp4=leather padding
Comp5=medium quality folded sheet metal 
Comp6=medium quality folded sheet metal 

[MQFSM]
Cont=Enviro
Comp0=smithy hammer
Comp1=block of medium quality ore
Comp2=water flask

[CE]
Cont=Mixing Bowl
Comp0=celestial solvent
Comp1=The Scent of Marr

[MT]
Cont=Enviro
Comp0=Celestial Essence
Comp1=Mistletoe
Comp2=Elven Wine

[Hilt]
Cont=Enviro
Comp0=ruby
Comp1=blessed dust of tunare 
Comp2=smithy hammer
Comp3=celestial essence
Comp4=sheet metal
Comp5=mistletoe temper
Comp6=Hilt mold

[Blade]
Cont=Enviro
Comp0=emerald
Comp1=blessed dust of tunare 
Comp2=smithy hammer
Comp3=celestial essence
Comp4=sheet metal
Comp5=mistletoe temper
Comp6=curved blade mold

[Pommel]
Cont=Enviro
Comp0=sapphire
Comp1=blessed dust of tunare 
Comp2=smithy hammer
Comp3=celestial essence
Comp4=sheet metal
Comp5=mistletoe temper
Comp6=pommel mold

[Sickle]
Cont=Enviro
Comp0=Blessed Sickle Blade
Comp1=Blessed Sickle Pommel 
Comp2=smithy hammer
Comp3=Blessed Sickle Hilt

[Dust]
Cont=Enviro
Comp0=Celestial Essence
Comp1=Imbued Emerald
Comp2=Jar of Acid

[VBits]
Cont=Enviro
Comp0=Spell: Enchant Velium
Comp1=Coldain Velium Temper
Comp2=Small Piece of Velium
Comp3=Small Piece of Velium

Hope this helps. I don't know how to put code into the seperate windows like you guys do ((.

Thanx for the help.
Toejam

 

[toejam]

Guess I lucked out and the window for the code took the script )) but both texts are there, the mac and the ini. ((

I just need to know how to get the pgm to 'clik' on the forge or brew barrel. The message is telling me it expects something different but I don't know. It doesn't sound like a massive change but I'm brain dead enuf to know when I need help. ))
Thanx again for your time. ))

 

[unknown405]

[code*]
1st code here
[/code]

[code*]
2nd code here
[/code]

Just take the *'s out.

 

[Jmo]

There ya go. I didn't realize it was two files at first, so I edited your post to make it all 1 code box. I changed it to split now.

 

[toejam]

Just wondering if anyone 'looked' at these to see why I am crashing? If noone did, ok, if someone did and changed something to make it correct, I'd kind a liked to know. ))
Been a while.
Respectfully,
toejam