Without a macro running, with a 2h weapon equipped, it still attempts to use the bash skill.
Tried doing an unload/load of mq2melee with the 2h weapon equipped at the start to see if it was holding a variable, but it behaved the same way.
Thank you for that update.
You may have unearthed a more fundamental bug.
The original code before I made amendments looked for the AA "Two-Handed Bash", which was valid until late 2019, in which EQ saw a patch to change the AA name to "Improved Bash" (for knights). As I haven't much experience with high level warriors, I was unaware of the level 105 AA, "Two-Handed Bash" for them until it was pointed out.
A boolean is used to store if the the character has the ability to 2 hand bash:
C++:
bool HaveBash = false; // Have Two Hand Bash?
The evolution of code is as follows
original code:
HaveBash = GetAAIndexByName("Two-Handed Bash");
paladins and shadow knights fix:
HaveBash = GetAAIndexByName("Improved Bash");
refix warriors:
HaveBash = GetAAIndexByName("Improved Bash") != 0 || GetAAIndexByName("Two-Handed Bash") != 0;
I'm reading the code in mq2utilties for GetAAIndexByName( "" ) and gettng concerned.
When I first bug hunted melee, the variable involved was boolean, and I took that call to evaluate true or false, indicating if the AA was bought by the character or not.
It looks like it will return a "postive" result if the AA exists for the class, regardless of level requirement or if it has been purchased.
I'm not saying that is an issue with GetAAIndexByName( "" ), but more how it's being used by melee.
Reviewing the options now on getting information returned with regards player bought AAs.
Regards and Best Wishes
Last edited: